File review request #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm-hiroshi
reviewed
Sep 15, 2023
|
|
||
| public function __construct() { | ||
|
|
||
| add_action( 'my_page', array( $this, 'add_my_page' ), 10 ); |
Contributor
There was a problem hiding this comment.
my_pageというhookは存在していますか？
このpluginは動作していますか？ @EiThandarAung-pressman
Collaborator
Author
|
関口さん、お疲れ様です。
中級１は今開発中なのでそれはまだです。ごめんなさいでした。
2023年9月15日(金) 15:54 pm-hiroshi ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In app/public/wp-content/plugins/wp10-midlevel1/wp10-midlevel1.php
<#2 (comment)>
:
> + }
+
+ class My_Test1 {
+ // ②
+ private static $instance;
+
+ public static function get_instance() {
+ if ( ! isset( self::$instance ) ) {
+ self::$instance = new self();
+ }
+ return self::$instance;
+ }
+
+ public function __construct() {
+
+ add_action( 'my_page', array( $this, 'add_my_page' ), 10 );
my_pageというhookは存在していますか？
このpluginは動作していますか？ @EiThandarAung-pressman
<https://github.com/EiThandarAung-pressman>
—
Reply to this email directly, view it on GitHub
<#2 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCPYYP2GKLL5USK3ERBHQGTX2P3TJANCNFSM6AAAAAA4ZKEA4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alert_on_loginフィイルをご確認お願い致します。